Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Don't trigger highlight if a new highlight is being created #265

Merged
merged 1 commit into from
Jul 31, 2017
Merged

Fix: Don't trigger highlight if a new highlight is being created #265

merged 1 commit into from
Jul 31, 2017

Conversation

pramodsum
Copy link
Contributor

  • Prevents other highlight dialogs from being triggered while a shared dialog for creating highlight annotations is already open

@Minh-Ng
Copy link
Contributor

Minh-Ng commented Jul 31, 2017

Any way we can leverage a pending thread state here instead of adding a new variable?

@pramodsum
Copy link
Contributor Author

isCreatingHighlight already exists actually. We set/unset it during mouseDown/mouseUp to prevent any annotations from triggering while you're dragging the mouse and highlighting text

@JustinHoldstock
Copy link
Contributor

And it's used BEFORE any state exists for an annotation(because the annotations don't exist yet)

@pramodsum pramodsum merged commit 9ab6db4 into box:master Jul 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinHoldstock JustinHoldstock JustinHoldstock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pramodsum @Minh-Ng @JustinHoldstock